kir4h / rvault

Small tool to perform some recursive operations on Hashicorp's Vault KV
MIT License
46 stars 11 forks source link

Added support for reading vault token from the ~/.vault-token file #4

Closed rabb1t closed 3 years ago

rabb1t commented 3 years ago

Hi!

Added minor changes to add the ability to read ~/.vault-token token helper file.

Thank you!

codecov[bot] commented 3 years ago

Codecov Report

Merging #4 (411b39b) into master (5e6163d) will decrease coverage by 0.91%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   90.52%   89.61%   -0.92%     
==========================================
  Files           6        6              
  Lines         285      260      -25     
==========================================
- Hits          258      233      -25     
  Misses         13       13              
  Partials       14       14              
Flag Coverage Δ
unittests 89.61% <ø> (-0.92%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/pkg/kv/kv.go 79.06% <0.00%> (-2.19%) :arrow_down:
internal/pkg/output/output.go 82.75% <0.00%> (-1.62%) :arrow_down:
internal/pkg/kv/list.go 90.16% <0.00%> (-0.61%) :arrow_down:
internal/pkg/kv/read.go 96.49% <0.00%> (-0.29%) :arrow_down:
internal/pkg/api/path.go 100.00% <0.00%> (ø)
internal/pkg/api/client.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e6163d...411b39b. Read the comment docs.

kir4h commented 3 years ago

Thanks for your contribution @rabb1t , I will take a look at it. In the meantime, maybe worth adding this somewhere in the README.md file? Currently there is a mention to VAULT_TOKEN at the end of the section, so maybe it could fit somewhere nearby

rabb1t commented 3 years ago

maybe worth adding this

Sure! Noted.