search

kirangeofran / pe

0 stars 0 forks source link

Unclear inputs for "rep" in add command #7

Open kirangeofran opened 4 months ago

kirangeofran commented 4 months ago

In the add command, you can say how many times to repeat the medication using the 'rep' input. In the UG it is unclear if this means to repeat in a week or something else. ( In this case, I am assuming it means how many times to repeat in a week based on the input being a number from 1-7). However, after you specify the numbers of times to take the medication per week, it does not allow you to say which days you want to take the medication. Thus, when you use the function list to check the medications you have to take for the day, it will give you all the medications in the list . This could be dangerous as perhaps you only have to take the medication on certain days, but could be consuming it wrongly

image.png

image.png

image.png

nus-se-bot commented 4 months ago

Team's Response

Thank you for pointing out this bug.

Each medication is added to the today list on the day that it was added into MediTracker, but for the daily list on subsequent days, the list is dictated by the corresponding repeat value.

I agree, the UG can be clearer, so this should at least be a DocumentationBug, to specify that 1 to 7 represents the number of days in a week. As this repeat does not hinder other functionality of the program, I have changed the severity from High to Low.

We can consider a future implementation to allow user to specify the day that they will start taking a medication, as currently, it is assumed that the user starts taking the medication on the day that it was added into MediTracker.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: I think it is a functionality bug as you have allowed the user to indicate how many days the medicine has to be repeatedly taken but you have not allowed the user to specify when to take it .

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** I don't think it makes sense for you to assume that the user starts taking the medication on the day it is added to the tracker. This does not make much sense to me, as I feel that you should allow the user to choose when they start taking the medication. In addition to this, how does the system decide which days you have to repeat the medication (e.g. a random generator or just the days in a row). I feel that this repeat does not work by itself and it either should be removed, or expanded upon to choose the days the medicine has to be taken.