Logging

[GoogleCodeExporter]

Currently logging is disabled. Introduce dependency to log4j or similar?

Original issue reported on code.google.com by dkocher@sudo.ch on 27 May 2011 at 1:21

[GoogleCodeExporter]

In r18.

Original comment by dkocher@sudo.ch on 27 May 2011 at 3:04

• Changed state: Fixed

[GoogleCodeExporter]

Does one want to keep the ch.ethz.ssh2.log.Logger class or log directly 
everywhere using java.util.logging?

Original comment by dkocher@sudo.ch on 28 May 2011 at 8:44

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

We need to be backwards compatible, i.e., by default do not fill up the console 
with logging messages (be completely quiet).

If we keep the Logger class, then we can use the "enabled" flag to keep the 
code quiet in the normal case (and save time, since all places in the code that 
invoke the logger always check first whether the logger is enabled before 
creating the log message). In my opinion, the log output should only be enabled 
during development and to produce bug reports.

Original comment by cleondris on 28 May 2011 at 9:00

[GoogleCodeExporter]

I would rather have logging in production depend on the log level and not on a 
boolean flag. Also it should be configurable with a settings file in the 
classpath without the need to recompile the source.

Therefore I would remove the check of the boolean flag everywhere but in the 
Logger class itself.

Original comment by dkocher@sudo.ch on 28 May 2011 at 9:06