Id3v2 write method writes id3v1 tags

kirankoyande / php-reader

Automatically exported from code.google.com/p/php-reader

0 stars 0 forks source link

Id3v2 write method writes id3v1 tags #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Using an example from wiki (example #6) method write() in both cases erases 
whole id3v2 data and adds id3v1 tags only. Lots of data are deleted then...

System: Mac OS X Snow Leopard (10.6.5)
PHP: 5.3.3

Original issue reported on code.google.com by gen.j...@gmail.com on 4 Feb 2011 at 1:21

Attachments:

polygon.php

GoogleCodeExporter commented 8 years ago

Same happens to me, using the latest trunk version. 

And I only retrieved the 'TALB' frame via getFramesByIdentifier, used setText 
and then wrote the changes back to the same file with write(null).

Hope you'll get around to look into it, this library seemed very promising! :)

Original comment by aseltenr...@gmail.com on 5 Mar 2011 at 2:12

GoogleCodeExporter commented 8 years ago

Seems like a serious error. I need to have a look at it. However, this won't 
happen in the next couple of weeks cos I've got a lot on my desk at the moment. 
In the mean time you could upload a sample file that you used to reproduce the 
issue. Thanks for reporting!

Original comment by svollbehr on 8 Mar 2011 at 9:09

Changed state: Accepted
Added labels: ID3v2, Priority-Critical
Removed labels: Priority-Medium

GoogleCodeExporter commented 8 years ago

I've tried to upload mine, but google refused it :(

Original comment by gen.j...@gmail.com on 9 Mar 2011 at 9:33

GoogleCodeExporter commented 8 years ago

Try putting it so a zip file or change the file extension?

Original comment by svollbehr on 9 Mar 2011 at 4:20

GoogleCodeExporter commented 8 years ago

Guys, I still need a sample file to replay the error scenario. Can one of you 
submit it here or send it to me via email so I can start working on this issue.

Original comment by svollbehr on 30 Apr 2011 at 8:17

GoogleCodeExporter commented 8 years ago

Mail sent.

Original comment by aseltenr...@gmail.com on 30 Apr 2011 at 8:43

GoogleCodeExporter commented 8 years ago

Thanks, I'll look into the issue now.

Original comment by svollbehr on 30 Apr 2011 at 8:53

Changed state: Started

GoogleCodeExporter commented 8 years ago

It seems like the solution for issue 41 has also fixed this issue. I had a look 
at the test case you sent me and it works now. Please update the issue if you 
guys find it otherwise.

Original comment by svollbehr on 2 May 2011 at 7:34

Changed state: Fixed