kiranma72 / abdm-docs

Documentation on various ABDM building blocks for developers
MIT License
4 stars 10 forks source link

Feedback on M1 #32

Open angshu opened 1 year ago

angshu commented 1 year ago

Explain ABHA number and ABHA address?

Section 2

2.1.1 > https://kiranma72.github.io/abdm-docs/2-milestone1/abha-number/aadhar-otp/index.html AADHAAR OTP

Steps

  1. “To enable beneficiary registration using Aadhaar, an integrator needs to generate an OTP and send the same on the linked mobile number.”
    • Does the integrator send the OTP, or the ABHA Service?
  2. “For the OTP verification process there is a primary mobile number which user wants to link with ABHA number.”
    • this is not done at this step. First the Aadhaar KYC is done .. then
  3. “Once the OTP is verified, system should returns the complete profile data along with 14 digit ABHA Number to the user.”
    • typo: system should return or system would return”

The API sequence diagram improvement

Describe encrypted payload - how do I create? With what key etc

Others

  • would it be better to describe for new patients, returning patients
  • or patients wanting to link with existing ABHA etc

API ——————————————————————————————— Seems unclear what is called at what point of time in relation to the sequence diagram above

Also seems different than what’s described In old doc - https://sandbox.abdm.gov.in/docs/abha_registration_via_aadhar Mentioned as - /api/v3/abha/request/mobileOrEmailOTP

However in the API section its https://abhasbx.abdm.gov.in/abha/api

  1. Session token https://dev.ndhm.gov.in/gateway/

Session token should it be “dev.abdm.gov.in/gateway”?

  1. Specify header - Authorisation bearer <>

Aadhaar Biometric - https://kiranma72.github.io/abdm-docs/2-milestone1/abha-number/aadhar-biometric/index.html Is this complete? If it is, it surely needs some example, even if dummy data

  1. Aadhaar demographic

“Any public health program specific ID (eg: PMJAY id, CoWin id, RCH Id) can be shared as part of the benefit id in the API”

“The client id used to call this API must have the integrated_program roll configured in production.”

sequence diagram says ‘returns ABHA address” - should be ABHA details as it sends both abha number (and if already assigned abha address) API response fields - please explain that the API returns (unlike the OTP) - healthIdNumber (ABHA) and healthId (Address) Actually its confusing in the API - as there is also a field “phrAddress” - an array - assuming sending all ABHA addresses

  1. (2.1.4) ABHA number creation using DL - https://kiranma72.github.io/abdm-docs/2-milestone1/abha-number/driving-license/index.html

  2. The idents / bullet styles are different - keep same across pages

  3. The actor is called “Client” .. keep consistent with other sequence diagrams

  4. API example in this section still gives details of “Aadhaar” instead should be document

  5. Please explain why OTP is required that too against Aadhaar when registering by DL? Who’s Aadhaar is this ? The enroller Aadhaar?

  6. (2.1.6) - default ABHA address.

    • How can someone create address of her liking?
  7. (2.1.7) - Profile Update

    • Is it better to document that Sandbox id and credentials are for testing purpose only and not to be used (or expected to be used) in production? As this section gives indication that there are 2 places, one can edit profile

2.2 - https://kiranma72.github.io/abdm-docs/2-milestone1/verify-abha-address/index.html

2.2.1 API Sequence Diagram

2.2.2 by demographics “The link token will be used for linking multiple number of care contexts, and concurrent linkages”

“Information Request Response for V3 API” https://kiranma72.github.io/abdm-docs/2-milestone1/verify-abha-address/health-facility-qr-scan/index.html#information-request-response-for-v3-api

The APIs are https://dev.abdm.gov.in/hiecm/api

Are these HIE-CM apis directly exposed to HIP, or through the gateway? If these APIs are called only by the PHR app - then we should document so.