Making the $server_type case-insensitive

[GoogleCodeExporter]

Not a bug, but a suggested enhancement to the sample code.

On or around line 107 of "/library/googlecart.php", the $server_type (3rd
argument of the constructor) tests for the a lower-cased string:

  if(strtolower($server_type) == "sandbox")

On or around line 54 of the file "/library/googlerequest.php", the same
line of code does not:

  if($server_type == "sandbox")

Suggestion: Apply the strtolower() to "/library/googlerequest.php". This
way, a developer could send "SANDBOX" and it would not accidentially submit
a request to the real (checkout.google.com) system.

Version: GC PHP Version: v1.2.1.

Original issue reported on code.google.com by tfl.mark...@yahoo.com on 22 Aug 2007 at 7:32

[GoogleCodeExporter]

Thx for the suggestion, im taking note for next release

ropu

Original comment by rovagn...@gmail.com on 22 Aug 2007 at 7:44

• Changed state: Accepted
• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

done in v1.2.5

Original comment by rovagn...@gmail.com on 3 Oct 2007 at 6:46

• Changed state: Fixed