kiranpatil353 / google-checkout-php-sample-code

Automatically exported from code.google.com/p/google-checkout-php-sample-code
0 stars 0 forks source link

Default shipping_tax not being set #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Add a default sales tax rule
2. The required element shipping-taxed is not generated 

What is the expected output? What do you see instead?
The element "shipping-taxed" should default to "false"

What version of the product are you using? On what operating system?
1.0.2

Please provide any additional information below.
In the googletax object (googletax.php) false should probably default to
the text false rather than the boolean. ie:
function GoogleDefaultTaxRule($tax_rate, $shipping_taxed = false)
//should be
function GoogleDefaultTaxRule($tax_rate, $shipping_taxed = "false")

Original issue reported on code.google.com by thephp...@gmail.com on 25 Feb 2007 at 6:51

GoogleCodeExporter commented 8 years ago
don't forget to set the default var as well

var $tax_rate;
var $shipping_taxed = "false";

Original comment by jmalban...@venicecreative.com on 12 Apr 2007 at 3:11

GoogleCodeExporter commented 8 years ago
try v1.2

Original comment by rovagn...@gmail.com on 13 Jun 2007 at 4:21