Bug: Fix for Query with Special Characters Failing Against Overseer

kiranshila / Doplarr

An *arr request bot for Discord

MIT License

407 stars 30 forks source link

Closed The-Running-Dev closed 5 months ago

The-Running-Dev commented 5 months ago

Modified Overseerr call to encode the query parameter
Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.

kiranshila commented 5 months ago

This is a good solution for now - but I think I need to figure out why hato wasn't URL-encoding everything.

The-Running-Dev commented 5 months ago

You know this issue...you commented on the Overseer repo...https://github.com/sct/overseerr/issues/2010

Look at my last comment here. https://www.reddit.com/r/Clojure/comments/1akfy0a/comment/kp9v1eo/?context=3 It's not that the encoding is wrong, it's that Hato is using + to encode spaces, but Overseer expects %20.

kiranshila commented 5 months ago

You know this issue...you commented on the Overseer repo...https://github.com/sct/overseerr/issues/2010

And I had promptly forgotten about it.