search

kiranshila / Doplarr

An *arr request bot for Discord
MIT License
437 stars 31 forks source link

fix(image): switch to adoptopenjdk/openjdk11:alpine-jre #20

Closed onedr0p closed 3 years ago

onedr0p commented 3 years ago

You may want to test this as I didn't have a chance to build Doplarr and test it.

kiranshila commented 3 years ago

Adoptopenjdk (my preferred JDK) has JRE builds for alpine that are half the side of the openjdk:11 image at 50MB

adoptopenjdk/openjdk11:alpine-jre

kiranshila commented 3 years ago

But switching to alpine means I need to understand all the apt stuff you did haha

onedr0p commented 3 years ago

I can do it in Alpine. I'll update this PR later today.

onedr0p commented 3 years ago

Do you also want doplarr to be built in the image? There's methods to do this that can still keep a light image.

kiranshila commented 3 years ago

Do you also want doplarr to be built in the image? There's methods to do this that can still keep a light image.

I don't think we need to. Github CI is building it and copying the JAR in and I don't think I need to debug in the image anymore.

onedr0p commented 3 years ago

@kiranshila updated, please verify :)

kiranshila commented 3 years ago

Thanks! Looks great!