search

kirazy / reskins-bobs

[Mod][Factorio] Reskins items, entities, and structures within Bob's mods to add tier coloring with player-customizable colors. Features high resolution icons, new, replacement sprites and models for many entities, and artisanal, hand crafted color masks, among other improvements. Part of the Artisanal Reskins series. Supports custom tier coloring for Miniloader, Loader Redux, Vanilla Loaders HD, and Deadlock's Crating and Beltboxes. Compatible with ShinyBobsGFX and ShinyAngelGFX.
MIT License
9 stars 5 forks source link

Mod Incompatibility - Picker Tweaks & Picker Pipe Tools #3

Closed Goatle closed 3 years ago

Goatle commented 4 years ago

Hi Kirazy,

Thanks for the great mod! Loving it.

I ran into an issue with the mod and two of the Picker series mods, namely Picker Tweaks and Picker Pipe Tools.

Using Reskin Bobs and these mods I get the following error on startup.

https://pastebin.com/mE79BXCJ

After disabling Picker Tweaks, Picker Pipe Tools then errors out with the following.

97.780 Error ModManager.cpp:1514: Error while loading entity prototype "pipe-clamped-single" (pipe-to-ground): Key "icon" not found in property tree at ROOT.pipe-to-ground.pipe-clamped-single.icons[0] Modifications: Picker Pipe Tools

The game then loads with these disabled. If I disable Reskin Bobs these errors do not occur.

I do have a load of additional mods, and can provide them if you need.

Additional Info:

Factorio Version 0.18.34

kirazy commented 4 years ago

I'd wager this is related to me setting icon = nil when I set the icons field. Then Picker Tweaks / Picker Pipe Tools comes along and expects icon, has no method to account for icons, and throws a startup error. This is a Picker Tweaks issue, icons supersedes icon when it is defined (so Picker Tweaks shouldn't be pulling from icon in the first place in this circumstance) so even if I were to not nil out the icon field, the issue remains that Picker Tweaks is pulling an inactive icon definition.

The specific case here is that Picker Tweaks is trying to modify the nuclear reactor (or even just fetch the icon?) and I have modified the nuclear reactor in data-updates.lua.

Goatle commented 4 years ago

Thank you for the super fast response and cross posting it over to Nexela's github.

Nice to know some of the specifics as to why this is not working.

kirazy commented 4 years ago

Both issues are the same, really. I nil out icon and Picker Tweaks and Picker Pipe Tools don't handle that properly.

kirazy commented 3 years ago

This is now fixed.

kirazy commented 3 years ago

Rather, the issue with Picker Tweaks is fixed. I'm checking the issue with Picker Pipe Tools now...

kirazy commented 3 years ago

There, now this is fixed. :)