search

kirby-deprecated-plugins / kirby-seo

51 stars 11 forks source link

<?php seo('title'); ?> don't seem to echo #22

Open jenstornell opened 8 years ago

olach commented 7 years ago

Well, this is the preferred behavior? The built in functions of Kirby has this behavior where you must manually echo the results.

I.e: https://getkirby.com/docs/cheatsheet/helpers/url

So in my opinion this issue should be closed. But the readme should reflect that you need to echo the results.

jenstornell commented 7 years ago

You might be right about that. This plugin became more complex than what I first encounted for. Therefor it would probably need a complete rewrite.

The reason I don't continue with the plugin right now is because of this issue:

https://github.com/getkirby/panel/issues/943

In short: In some rare cases it mess up a panel page on a multi language site.

It's tagged milestone 2.5 so maybe it will be solved but it could be pushed to 2.6 or 2.7, who knows. I'll keep this open because of the possible readme problem.

olach commented 7 years ago

Alright. Hopefully the panel issue will get resolved.

I just made a PR #33 of some edits I have made locally to improve this plugin. Among other things, I made so that the plugin always returns the values, instead of echoing them. That is the way Kirby mostly does it.