kirby-deprecated-plugins / kirby-seo

51 stars 10 forks source link

Path issue on some environments #23

Closed jenstornell closed 7 years ago

jenstornell commented 8 years ago

vardagsfinans.se

abroess commented 8 years ago

I've got the same issue on a localhost installation. Perhaps a little workaround will help:

// Url preview
public static function urlPreview( $url ) {
    $url_parts = parse_url($url);
    $scheme = ( $url_parts['scheme'] == 'https' ) ? 'https://' : '';
    if( empty($url_parts['path'] ) ) {
        $uri = $scheme . $url_parts['host'];
    } else {
        $uri = $scheme . $url_parts['host'] . $url_parts['path'];
    }

    return $uri;
}
bezin commented 8 years ago

I can confirm this. @abroess fix helped me as well

TimOetting commented 8 years ago

I can confirm this too

luxlogica commented 7 years ago

This seems to be the same error as reported in Issue #30.

Can still confirm the same issue with Kirby 2.5.4, running on a Mac with MAMP.

Can also confirm that the fix proposed by @abroess fixed it! 👍

Perhaps this should be added to the next version, and this bug closed?

abroess commented 7 years ago

I made a pull request #43

jenstornell commented 7 years ago

Sorry for the delay. I will make a complete rewrite of this field for Kirby 3. But now that @abroess sent me a pull request I've merged it. I simply trust in your comments that it's working.

Thanks!