[Enhancement] Change color for Sparekassen Sjælland-fyn

alxzak commented 3 years ago

[ ] I have written a good issue

Describe the enhancement

Beskrivelse På et tidligere intromøde for hjemmesideredaktører mv. præsenterede Team Kirby deres koncept. Herunder stillede jeg et spørgsmål om vi kan rette lyskurven (rød - gul - grøn) i Mobilbanken og svaret var at det sagtens kan lade sig gøre. Så derfor vil vi gerne have ændret farverne i Mobilbank så de matcher vores farve univers/design manual. Overtræksgul skal fremover være #f7aa4e Den rød ved bl.a. investering skal fremover være #eb5f60 Den grønne må gerne skifte til vores primære logofarve/CTA #83C6A9 – hvis muligt

Meld gerne retur hvis i ser nogle problemer eller andre issues

Link til sagen: Konsulentydelse 1131215

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

[ ] Request that the issue is UX refined; do not proceed until this is done.
[ ] Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

[ ] Make sure you have read: "Before you get coding".
[ ] Signal to others you are working on the issue by assigning yourself.
[ ] Create a branch from the master branch following our branch naming convention.
[ ] Publish a WIP implementation to Github as a draft PR and ask for feedback.
[ ] Make sure you have implemented tests following the guidelines in: "The good: Test".
[ ] Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

[ ] Do a self-review.
[ ] Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".

alxzak commented 3 years ago

Promark number is pending.

bommariusser commented 3 years ago

er det notifikation colors @alxzak ?

jkaltoft commented 3 years ago

Description in english, please 😊

bommariusser commented 3 years ago

@alxzak answer <3

alxzak commented 3 years ago

@bommariusser - It is the notification colors! :)

jkaltoft commented 3 years ago

Suggestion for solution

Change the apps/relationsbank/src/scss/bank/spks/theming/_colors.scss partial to:

$brand-colors: (
  'primary': #83c6a9,
  'secondary': #328639,
  'tertiary': #00594e,
);

$notification-colors: (
  'success': #83c6a9,
  'warning': #f7aa4e,
  'danger': #eb5f60,
);

$drb-colors: generate-colors(map-merge($brand-colors, $notification-colors));

@import '../init-kirby';

kirbydesign / designsystem