kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
82 stars 22 forks source link

[Housekeeping] Fix modal-footer and dropdown related failing tests #2654

Open RasmusKjeldgaard opened 1 year ago

RasmusKjeldgaard commented 1 year ago

Describe the housekeeping request

We have a couple of tests that are sporadically (but quite often) failing both locally and in Github Actions:

image

Are there any additional context?

Seems like this could be good ol' ResizeObserver that needs to run before we measure, at least that could be the case for dropdown. It has been a recurring issue, and last time we just fixed it temporarily: https://github.com/kirbydesign/designsystem/pull/2411

If a robust fix is possible, consider closing this issue and implement as this one instead - that would be preferable! https://github.com/kirbydesign/designsystem/issues/2413

kodeaben commented 1 year ago

The sporadic test fails occur in radio-group.component.spec and dropdown.component.spec The complexity and quality of the radio-group.component.spec makes it very difficult to actually determine the underlying issue. I recommend that we consider re-writing this spec: https://github.com/kirbydesign/designsystem/issues/2658