kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
82 stars 22 forks source link

[Housekeeping] Align seperate modal version and combine into one (Modal v1 <- v2) #2854

Closed mark-drastrup closed 8 months ago

mark-drastrup commented 1 year ago

⚠️ This issue is dependent on the new alert issue ⚠️

By cleaning up the old modal code we will delete the alert as well, since it is instantiated through the modal controller.

Describe the housekeeping request

When the experimental modal becomes the new default modal, we should remember to clean up the following files and foldes:

Folders

Files

After all the files have been removed, then all the modal-experimental names must be changed to modal. When the renaming is done the following files should be updated:

RasmusKjeldgaard commented 8 months ago

We are introducing the declarative modal in modal v1 instead to avoid heavy refactoring in consumer projects. Modal v2 can be removed when the declarative modal is introduced to modal v1 as teams will have a vialbe migration path away from v2.