Closed mark-drastrup closed 8 months ago
We are introducing the declarative modal in modal v1 instead to avoid heavy refactoring in consumer projects. Modal v2 can be removed when the declarative modal is introduced to modal v1 as teams will have a vialbe migration path away from v2.
⚠️ This issue is dependent on the new alert issue ⚠️
By cleaning up the old modal code we will delete the alert as well, since it is instantiated through the modal controller.
Describe the housekeeping request
When the experimental modal becomes the new default modal, we should remember to clean up the following files and foldes:
Folders
libs/designsystem/modal/src
. Theexperimental
folder should become the newsrc
.apps/cookbook/src/app/examples/modal-example
apps/cookbook/src/app/showcase/modal-showcase
Files
libs/core/src/scss/_global-styles.scss
libs/core/src/scss/base/_variables.scss
libs/designsystem/src/lib/kirby.module.ts
After all the files have been removed, then all the
modal-experimental
names must be changed tomodal
. When the renaming is done the following files should be updated:libs/designsystem/tsconfig.json
libs/designsystem/tsconfig.spec.json
apps/flows/tsconfig.json
apps/cookbook/tsconfig.json