kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
84 stars 23 forks source link

[Enhancement] Interaction states adjustments #3099

Open henrikvoetmand opened 1 year ago

henrikvoetmand commented 1 year ago

Describe the enhancement

PLACEHOLDER ISSUE We need to adjust hover and pressed state values ("loudness") for several components:

Maybe create som design tokens for the values.

Describe the solution you'd like

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

RasmusKjeldgaard commented 1 year ago

A small adjustment that would be beneficial to do when we are looking at this is using outline instead of border for our focus ring, to avoid this issue when focus ring is applied on other types of backgrounds than light and white:

image

Previously this was not an option due to safari not respecting the border radius for outline, which would result in a square focus indicator. This is now fixed, and only older versions will be affected. @henrikvoetmand and I have deemed that a fair tradeoff, instead of everyone seeing the issue above.