kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
84 stars 22 forks source link

[Enhancement] No shadow on Slider cards #3135

Closed henrikvoetmand closed 10 months ago

henrikvoetmand commented 1 year ago

Describe the enhancement

The default cards has a drop shadow. When cards are used in Slider component, the card shadow is hidden by the "swiper-container" (overflow = hidden). The result is that the cards does not look right.

We still need the "swiper-container" to hide the cards that are not in view.

Describe the solution you'd like

Find a new way to hide cards not in view, but keep the card shadow visible.

Have you considered any alternatives?

No

Are there any additional context?

Card shadow hidden: Skærmbillede 2023-06-29 kl  10 35 19

Card shadow NOT hidden:

Skærmbillede 2023-06-29 kl  10 43 08

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

troelslenda commented 11 months ago

I noticed the same. Here I changed kirby-card box-shadow to red to provide better visuals. image

troelslenda commented 11 months ago

image