kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
84 stars 22 forks source link

[BUG] Cannot build on a completely new blank project (Swiper dependency) #3222

Closed Hykalos closed 1 year ago

Hykalos commented 1 year ago

Describe the bug

When starting from scratch, the project doesn't build because a type in Swiper can't be found (SwiperOptions)

Describe how to reproduce the bug

  1. Set up a new empty Angular project
  2. Use the guide to include Kirby to your project
  3. Try and run the project

Which Kirby version was used?

8.11.1

What was the expected behavior?

The project runs

Add any screenshots

d6bd388c-d08e-45d6-9e8c-fa4048aceb42

Please complete the following information:

Are there any additional context?

Forcing swiper to be version 9.X works. The missing type doesn't exist in version 10.X


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

RasmusKjeldgaard commented 1 year ago

Hi @Hykalos, thanks for bringing this to our attention! A workaround until we have a fix for this is to install Swiper 9 manually in your project.

RasmusKjeldgaard commented 1 year ago

Verified, and reproducible with the following steps:

  1. Create a new angular project, e.g. npx -p @angular/cli ng new angular-16
  2. npm i @kirbydesign/designsystem
  3. import KirbyModule in app module
  4. npm start