issues
search
kirbydesign
/
designsystem
Kirby Design System
https://cookbook.kirby.design
MIT License
84
stars
22
forks
source link
[Testing] Re-configure Chromatic CI workflow
#3388
Closed
RasmusKjeldgaard
closed
3 months ago
RasmusKjeldgaard
commented
7 months ago
[x]
Run chromatic on Github action push event to avoid losing baselines:
https://www.chromatic.com/docs/github-actions/#recommended-configuration-for-build-events
Seems like this is unneccessary, I have enabled the Chromatic Github app instead, which should carry over the baselines:
https://www.chromatic.com/docs/github-actions/#github-squashrebase-merge-and-the-main-branch
[x] How do we avoid running snapshot tests for each and every push to a PR?
Only run before merge of every PR? A label on PR?
[ ] Configure Github branch protection rules to require status checks to pass before merging - both
chromatic
and
UI Tests
[x] Enable
UI Review powered by stories
Run chromatic on Github action push event to avoid losing baselines: https://www.chromatic.com/docs/github-actions/#recommended-configuration-for-build-eventschromatic
andUI Tests