kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
82 stars 22 forks source link

[Enhancement] Add min-width to chip in Segmented Control compact mode #3416

Open dennispedersen-bd opened 3 months ago

dennispedersen-bd commented 3 months ago

Describe the bug

The small chip is not circular. There is 1px difference in the ratio. Skærmbillede 2024-03-14 kl  15 41 06 ## Describe how to reproduce the bug ## What was the expected behavior?

Add any screenshots

Please complete the following information:

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

RasmusKjeldgaard commented 3 months ago

This is working as intended, as the chips width is dependent on its content. So for instance, with my selected text size in the browser this chip will be round:

image

While this will not:

image

If the segmented control should support circular chips, please consider submitting an enhancement.

RasmusKjeldgaard commented 3 months ago

Reopening as a request for added functionality to the chip, as this is not a bug.

dennispedersen-bd commented 3 months ago

Artboard Design spec on minimum width.

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.