kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
82 stars 22 forks source link

[BUG] Paragraphs are missing 16px margin not aligning with UI guidelines #3429

Open simonequach opened 3 months ago

simonequach commented 3 months ago

Describe the bug

Paragraphs are missing 16px margin not aligning with UI guidelines. Leaving it up to every team to manually add it, potentially causing problems and a lot of UI debt on the long run, if changes in the UI guidelines are made.

What was the expected behavior?

That a 16px margin is default, aligning text with headers as required in the UI guidelines.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

jakobe commented 2 months ago

@simonequach We need more info on this: On which side(s) do you want the margin? Top/Bottom? Left/Right? Would be great if you could add a screenshot of the changes you would like to see 🤞🏻

simonequach commented 2 months ago

@jakobe it's missing on the lefthand side, so headers and paragraphs doesnt align. Henrik is aware of this. Every team fix it manually, so I do not have a photo to show.