Type passed to items will be passed back with segmentSelect()
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Are there any additional context?
A custom implementation of NoInfer has to be introduced until TypeScript 5.4 has been upgraded to which provide built-in support for NoInfer
The property isCustomIcon on SegmentItem has been removed since it was seemingly unused. This eliminates the need for SegmentItemInternal as well.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
[ ] Make sure you have implemented tests following the guidelines in: "The good: Test".
[ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).
Review
[ ] Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
Which issue does this PR close?
This PR closes #3453
What is the new behavior?
Type passed to
items
will be passed back withsegmentSelect()
Does this PR introduce a breaking change?
Are there any additional context?
A custom implementation of
NoInfer
has to be introduced until TypeScript 5.4 has been upgraded to which provide built-in support forNoInfer
The property
isCustomIcon
onSegmentItem
has been removed since it was seemingly unused. This eliminates the need forSegmentItemInternal
as well.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.