Modal: alert not closing on browser back navigation - Githubissues

kirbydesign / designsystem

Kirby Design System

https://cookbook.kirby.design

MIT License

82 stars 22 forks source link

Modal: alert not closing on browser back navigation #3495

Closed jakobe closed 2 weeks ago

jakobe commented 3 weeks ago

Which issue does this PR close?

This PR closes #3430 and fixes #3465

What is the new behavior?

Ensures the alert is only shown once, when closing a route based modal.
Adds support for a CanDismissModalGuard which handles browser back navigation (popstate) by either preventing or allowing navigating away from the modal when the canDismiss callback is set.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

[ ] Make sure you have implemented tests following the guidelines in: "The good: Test".
[ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

[ ] Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
[ ] Do a self-review.
[ ] Request that the changes are code-reviewed
[ ] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.