Similar to the Angular packages we now consume the core package from the dist folder.
This means we use the compiled output like a library, similar to our consumers. This is a better alternative than offloading the compilation of any core components to the cookbook or storybook application-builders and thus consuming it differently when developing, as typescript configs, bundling etc. might differ.
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
[ ] Make sure you have implemented tests following the guidelines in: "The good: Test".
[ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).
Review
[x] Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
Which issue does this PR close?
This PR closes no issue
What is the new behavior?
Similar to the Angular packages we now consume the core package from the dist folder.
This means we use the compiled output like a library, similar to our consumers. This is a better alternative than offloading the compilation of any core components to the cookbook or storybook application-builders and thus consuming it differently when developing, as typescript configs, bundling etc. might differ.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.