kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
82 stars 22 forks source link

Modal footer: apply correct theme variables for nested elements inside footer #3508

Closed Fuzzy3 closed 1 week ago

Fuzzy3 commented 1 week ago

Which issue does this PR close?

This PR fixes an issue where grey buttons (buttons with attentionLevel="3") in an inline footer would not change their color to white, when modal footer has type="inline" An example code snippet of the use would look like this:

<kirby-modal-footer type="inline">
  <button kirby-button attentionLevel="3">Click Me</button>
</kirby-modal-footer>

And the output of this snippet would show a grey button on a grey background when a modal footer is set as inline, which makes the button not stand out:

image

What is the new behavior?

When the type="inline" is added to a modal footer, the correct theme (light-theme) will be applied causing the grey buttons within the modal footer to properly turn white.

The output will now look like this:

image

Does this PR introduce a breaking change?

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

Review

When the pull request has been approved it will be merged to develop by Team Kirby.