kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
85 stars 23 forks source link

[Enhancement] Adjustments for Image Banner #3670

Closed troelslenda closed 2 weeks ago

troelslenda commented 1 month ago

Describe the enhancement

With our use of Image Banner, we discovered that we need to be able to truncate bodytext with ellipsis in the same way the title is already truncated. We also need the title to be able not to truncate. Further more the min height is not ideal since we in some cases do not have any body text.

Describe the solution you'd like

To have handles/inputs to define wether or not to truncate text and wether or not to have a min height.

Have you considered any alternatives?

Instead of having seperate inputs for these 3 settings, I considered passing a config object instead.

Are there any additional context?

Screenshot 2024-10-19 at 15 50 26


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review: