kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
85 stars 23 forks source link

[Enhancement] Make `usePopover` default behavior in dropdown #3696

Open RasmusKjeldgaard opened 2 weeks ago

RasmusKjeldgaard commented 2 weeks ago

Describe the enhancement

There are some reports about dropdown not correctly placing itself on top of content , e.g. #3691 and others raised in our support channels. These have proven to be solved by usePopover="true", so we should make it the default. It is battle-tested, and known issues have been solved as per https://github.com/kirbydesign/designsystem/issues/2087.

Solving this issue will also solve above mentioned issue (#2087).

Also, consumers have to explicitly set usePopover for dropdown in calendar, which is not ideal, and would also be solved by this.

Describe the solution you'd like

Make usePopover true by default and deprecate the input all together, by warning when it is set. Remove the input all together in the next major.

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review: