Button: add a11y documentation for icon only button - Githubissues

kirbydesign / designsystem

Kirby Design System

https://cookbook.kirby.design

MIT License

85 stars 23 forks source link

Button: add a11y documentation for icon only button #3713

Closed jakobe closed 1 week ago

jakobe commented 1 week ago

Which issue does this PR close?

This PR closes #3709

What is the new behavior?

Added a new section on a11y for icon only buttons
Icon only buttons with text and [showIconOnly]="true" makes the button text available to AT (visually hidden)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

[x] Make sure you have implemented tests following the guidelines in: "The good: Test".
[x] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

[x] Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
[x] Do a self-review.
[x] Request that the changes are code-reviewed
[ ] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.