kirbydesign / designsystem

Kirby Design System
https://cookbook.kirby.design
MIT License
83 stars 22 forks source link

[Enhancement] Image Flavors (Card & Modal) #956

Open bommariusser opened 4 years ago

bommariusser commented 4 years ago

Is your enhancement request related to a problem? Please describe. Our cards and modals can right now only be shown in a simple form.

Even though some teams use Images in Cards, there is no "one way to do it". So when looking at performance, loading etc. of the images there is no technical standard.

Describe the solution you'd like We would like to be able to place Images inside some of our components like Cards and Modals.

Cards: Should fill the whole card - See also

Skærmbillede 2020-03-16 kl  14 51 22

Modals: Should fille the top of a modal and the content should scroll away like it would be a drawer that scrolls up.

Skærmbillede 2020-03-16 kl  14 51 17

Describe alternatives you've considered In a modal it is basically the hero picture as also described here https://material.io/design/communication/imagery.html#hero-images

Additional context We should handling loading our images consistently, like blurring the image or something instead of showing nothing until the image has been loaded.

Look also at Wolt how they load their pictures, they are blurred in a low quality version until they have the picture.

IMG_5581

jakobe commented 3 years ago

@bommariusser Isn't the 2nd part of this issue a duplicate of #1300 ? 🤔

MadsBuchmann commented 2 years ago

I' beginning work on the card part of this issue in: https://github.com/kirbydesign/designsystem/issues/2022 :D