search

kirbyju / tcia_utils

A package to simplify common tasks one might perform when interacting with The Cancer Imaging Archive (TCIA) via Python.
Apache License 2.0
15 stars 4 forks source link

ipykernel imports problematic #6

Closed zjp closed 1 year ago

zjp commented 1 year ago

It doesn't look like this library actually uses the ipykernel imports, but I could have missed something (the star import makes it difficult to tell).

Are there plans to use these?

kirbyju commented 1 year ago

https://ipywidgets.readthedocs.io/en/stable/examples/Using%20Interact.html is being used in the viewSeries() function. Looks like it could be cleaned up a bit from:

from ipywidgets.widgets import * 
import ipywidgets as widgets

to:

from ipywidgets import interact

Would that address your concern?

zjp commented 1 year ago

Well, it's still worth doing but I was really hoping we didn't actually need it and I could sidestep a bug in ChimeraX relating to zmq not shipping real universal wheels (there's a library in the x86 version that's not in the arm64 version).

Darn! I've got to go take it up with them now. :p

kirbyju commented 1 year ago

Oh, that reminds me, I saw your helpdesk ticket about adding a TCIA Browser typed thing to ChimeraX. Keep me posted on your progress! I'm happy to help review the implementation when you're ready to make sure it meets our Data Usage Policy attribution requirements. We would also like to add it to https://wiki.cancerimagingarchive.net/x/x49XAQ and help spread the word when it's done!

zjp commented 1 year ago

Thank you, I will!