search

kirei / catt

Certification Authority Trust Tracker
124 stars 16 forks source link

Mozilla EV tool not working #12

Closed jschlyter closed 2 years ago

jschlyter commented 8 years ago

extract-mozilla-ev.py seems to be not functioning, could you please take a look?

secworks commented 8 years ago

Sure, I'll look and fix.

secworks commented 8 years ago

it seems that the moz source has been moved into a new repo: https://mxr.mozilla.org/mozilla-central/source/security/certverifier/ExtendedValidation.cpp?raw=1

But reading that site seems to suggest that one should not use DXR either, but use Moz repos on Github. Googling ended up pointing to Moz-Gecko. And indeed there is a similar file there: https://raw.githubusercontent.com/mozilla/gecko-dev/master/security/certverifier/ExtendedValidation.cpp

Similar being the operating word. The moz parser can read the file, but the results is incorrect.

secworks commented 8 years ago

I just committed a fix in c7863089236caef2e843edb25580d44f0c069556. It seems to work, but please check that it really does.

jschlyter commented 8 years ago

How come the fingerprints are 42 nibbles, should it be 40?

secworks commented 8 years ago

No should be 64 nibbles. The new source code parsed have the fingerprint byte values on three lines, not two. Could probably be parsed in a more robust way. There is a fix in https://github.com/kirei/catt/commit/3cd323bfd5ba3201f2c66c2d4492302fa267c2ac.

secworks commented 2 years ago

We can probably close this issue.