Problems on 5.4

[okeuday]

I attempted to do build-release.sh with all the tarballs from the 5.4 cdroms in diststuff (with src/sys from the ftp mirror). The error I got is below (do you know why I would have an error like this, that would have prevented builds for other people? is this a flashboot problem at-all? or does the 5.4 release just have some compiler warnings left-in?):

===> sys/arch/i386/stand/boot
cc  -m32  -fno-pie  -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d  -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot  -c /usr/src/sys/arch/i386/stand/boot/srt0.S
cc   -Os -Wall -Werror -fno-stack-protector -Wall -Wpointer-arith -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes -Wunused -Wsign-compare -Wbounded -Wshadow -Wdeclaration-after-statement  -m32 -D_STANDALONE -nostdinc -fno-builtin -fpack-struct -D__INTERNAL_LIBSA_CREAD -fno-pie  -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d  -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot  -c /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/boot.c
cc   -Os -Wall -Werror -fno-stack-protector -Wall -Wpointer-arith -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes -Wunused -Wsign-compare -Wbounded -Wshadow -Wdeclaration-after-statement  -m32 -D_STANDALONE -nostdinc -fno-builtin -fpack-struct -D__INTERNAL_LIBSA_CREAD -fno-pie  -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d  -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot  -c /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c
cc1: warnings being treated as errors
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'read_conf':
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:141: warning: comparison between signed and unsigned
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'docmd':
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:218: warning: comparison between signed and unsigned
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'readline':
/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:307: warning: comparison between signed and unsigned
*** Error 1 in sys/arch/i386/stand/boot (<sys.mk>:87 'cmd.o')
*** Error 1 in sys/arch/i386/stand (<bsd.subdir.mk>:48 'all')
*** Error 1 in sys/arch/i386 (<bsd.subdir.mk>:48 'all')
*** Error 1 in sys (<bsd.subdir.mk>:48 'all')
*** Error 1 in . (<bsd.subdir.mk>:48 'all')
*** Error 1 in /usr/src (Makefile:89 'build')
DONE! Now build kernel.

[jryberg]

Are you building from i386 or amd64?

Best regards Johan Ryberg Den 9 jan 2014 05:44 skrev "Michael Truog" notifications@github.com:

I attempted to do build-release.sh with all the tarballs from the 5.4 cdroms in diststuff. The error I got is below (do you know why I would have an error like this, that would have prevented builds for other people? is this a flashboot problem at-all? or does the 5.4 release just have some compiler warnings left-in?):

===> sys/arch/i386/stand/boot cc -m32 -fno-pie -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot -c /usr/src/sys/arch/i386/stand/boot/srt0.S cc -Os -Wall -Werror -fno-stack-protector -Wall -Wpointer-arith -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes -Wunused -Wsign-compare -Wbounded -Wshadow -Wdeclaration-after-statement -m32 -D_STANDALONE -nostdinc -fno-builtin -fpack-struct -D__INTERNAL_LIBSA_CREAD -fno-pie -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot -c /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/boot.c cc -Os -Wall -Werror -fno-stack-protector -Wall -Wpointer-arith -Wuninitialized -Wstrict-prototypes -Wmissing-prototypes -Wunused -Wsign-compare -Wbounded -Wshadow -Wdeclaration-after-statement -m32 -D_STANDALONE -nostdinc -fno-builtin -fpack-struct -D__INTERNAL_LIBSA_CREAD -fno-pie -I/usr/src/sys/arch/i386/stand/boot/../../../.. -I/usr/src/sys/arch/i386/stand/boot/../libsa -I. -I/usr/src/sys/arch/i386/stand/boot -DSOFTRAID -DBOOTMAGIC=0xc001d00d -DLINKADDR=0x40120 -DSLOW -DSMALL -DNOBYFOUR -DNO_GZIP -DDYNAMIC_CRC_TABLE -DHEAP_LIMIT=0x90000 -I/usr/src/sys/arch/i386/stand/boot/../../../../stand/boot -c /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c cc1: warnings being treated as errors /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'read_conf': /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:141: warning: comparison between signed and unsigned /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'docmd': /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:218: warning: comparison between signed and unsigned /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c: In function 'readline': /usr/src/sys/arch/i386/stand/boot/../../../../stand/boot/cmd.c:307: warning: comparison between signed and unsigned * Error 1 in sys/arch/i386/stand/boot (:87 'cmd.o') * Error 1 in sys/arch/i386/stand (:48 'all') * Error 1 in sys/arch/i386 (:48 'all') * Error 1 in sys (:48 'all') * Error 1 in . (:48 'all') * Error 1 in /usr/src (Makefile:89 'build') DONE! Now build kernel.

— Reply to this email directly or view it on GitHubhttps://github.com/openbsd/flashboot/issues/33 .

[okeuday]

i386 for a soekris 4511

[jrmakosky]

Remove "WARNINGS" line in mk-mini.conf. I'm preparing a pull request with this, and a couple other changes.

[okeuday]

I found out that this was being caused by a hard disk problem, so this isn't related to the OpenBSD source code, from what I can tell. I haven't had a chance to retry flashboot, yet. Since the original issue is invalid, I am going to close this, but watch for your changes.

[jrmakosky]

I am testing my changes, and am frankly kind of mystified, as to exactly why removal of the WARNINGS line allows "make build" to complete.

[okeuday]

Thanks for mentioning this. The error above should have been caused by -Werror getting into the command-line, so I would assume that having WARNINGS in mk-mini.conf makes -Werror find its way into the cc command-line, but I am unsure how. Since I was compiling the 5.4 release src tarball from the mirror, it should be due to that configuration, rather than the tarball.