search

kirenbahm / ENP_TOOLS

Scripts used to pre- and post-process data
0 stars 2 forks source link

Issues 13 and 15 #20

Closed LAGO-Support closed 4 years ago

LAGO-Support commented 4 years ago

Changes to boxplotMONTH.m and boxplotYEAR.m that fix issues 13 and 15, which were errors when no data is present and escape characters in the title, respectively.

kirenbahm commented 4 years ago

I ran ANALYSIS_COMPARE.m, but no boxplots were generated for me. Were you able to get boxplots generated when you tested this script?

I ran ANALYSIS_COMPARE.m after settingINI.INCLUDE_OBSERVED = 0. The script did not produce any plots at all. Were you able to get this to work when you tested it?

LAGO-Support commented 4 years ago

I did run and was able to get boxplots. When I compared what I edited on GitHub and what our local files had I noticed the incorrect conditional. I tested on our end again to be sure and it generated the boxplots.

As for running with INI.INCLUDE_OBSERVED = 0, this seems to be a different issue. I ran this as well and the STATION going to the boxplot function has no data and is thus caught by the first conditional that checks for NaN values at line 4. The changes I made to the boxplot for this issue didn't cause this.

kirenbahm commented 4 years ago

Thanks for the response. I see we have 3 different issues being discussed. I will attempt to untangle them:

Issue #15: Backslash removal Your code changes fixed this issue. Because it was combined with the boxplot issue, things got a little confusing. So, I copied your fix for #15 into a separate commit, merged it into the master, unlinked #15 from this pull request, and closed #15.

Issue #13: Boxplots not working when INI.INCLUDE_COMPUTED = 0 The code fixes you made still do not fix this issue for me, but you said that this is working on your machine. Let's get together on WebEx to figure it out together. :)

Issue #5 : Running script with INI.INCLUDE_OBSERVED = 0 As you mentioned above, this is indeed a separate issue. It was my error. I was mixing up the INI.INCLUDE_COMPUTED and INI.INCLUDE_OBSERVED variables. This issue did indeed exist before you made any edits, and you did not cause this. My apologies!