search

kirenbahm / ENP_TOOLS

Scripts used to pre- and post-process data
0 stars 2 forks source link

Data correction issue6 new #28

Closed LAGO-Support closed 4 years ago

LAGO-Support commented 4 years ago

Was trying to perform the I and J value checks on all lines, including the M11 data that has empty values. Added a line to check if xls row is MSHE data before performing I and J value checks.

kirenbahm commented 4 years ago

This looks like the problem is fixed. However, the warning message is a little confusing:

Warning: Station NP201 at excel row 470 with a coordinate indexes of (300 , 167) is estimated as (1.743037e+02 , 1.672059e+02) based on model domain dfs2

Shouldn't the coordinates (1.743037e+02 , 1.672059e+02) be integers?

Let me know what you think should be done here.

Thanks.

LAGO-Support commented 4 years ago

Edited readFileCompCord to fix the scientific notation text in the warning

kirenbahm commented 4 years ago

This still doesn't seem right to me. For example, I am getting the following warning for a station in the middle of the model domain: --- Warning: Station NE2 at excel row 459 with a coordinate indexes of (215 , 167) is estimated as (216 , 168) based on model domain dfs2

LAGO-Support commented 4 years ago

Made adjustment in I, J check to account for half cell offset in the preprocessed domain file

kirenbahm commented 4 years ago

This commit looks good and completes the task.

Because this branch and the master have diverged so much during the development of this feature, I decided to copy these edits from branch 'DataCorrectionIssue6-new' into a new-new branch called 'DataCorrectionIssue6-new-new'. This was simpler to do cleanly instead of resolving the merge conflicts from this branch.

I will close this pull request without merging, and merge these edits into the master via the new-new branch.

Thanks for your work on this.