Closed aroop closed 1 year ago
Thanks, @aroop! A very welcome fix and nicely explained too. Many thanks. :pray: :tada:
:tada: This PR is included in version 1.6.0 :tada:
The release is available on:
v1.6.0
Your semantic-release bot :package::rocket:
This pull request addresses an issue in the HTTPStorage class, specifically in the
download_file
method. Previously, the method would fail and crash if the 'content-disposition' header was missing from the HTTP response. This is a common scenario, especially when dealing with servers that don't include this optional header.download_file
method inHTTPStorage
to use theget
method when accessingresp.headers["content-disposition"]
. This will returnNone
instead of raising an exception if the header is missing.None
before attempting to parse it with a regular expression.This fix will prevent the application from crashing when attempting to download files from servers that do not include a 'content-disposition' header. The application's robustness and reliability will be improved, especially in diverse server environments.