kiri-art / docker-diffusers-api

Diffusers / Stable Diffusion in docker with a REST API, supporting various models, pipelines & schedulers.
https://kiri.art/
MIT License
202 stars 94 forks source link

Fix Crash When 'Content-Disposition' Header Is Missing #37

Closed aroop closed 1 year ago

aroop commented 1 year ago

This pull request addresses an issue in the HTTPStorage class, specifically in the download_file method. Previously, the method would fail and crash if the 'content-disposition' header was missing from the HTTP response. This is a common scenario, especially when dealing with servers that don't include this optional header.

This fix will prevent the application from crashing when attempting to download files from servers that do not include a 'content-disposition' header. The application's robustness and reliability will be improved, especially in diverse server environments.

gadicc commented 1 year ago

Thanks, @aroop! A very welcome fix and nicely explained too. Many thanks. :pray: :tada:

gadicc commented 1 year ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: