ESLint hook doesn't stop commit on warnings

kiriDevs / vplanweb

A web app for the substitution plan of my school - data is supplied by an API maintained by @ChuangSheep

https://vplan.kiridevs.live

3 stars 0 forks source link

ESLint hook doesn't stop commit on warnings #79

Open kiriDevs opened 2 years ago

kiriDevs commented 2 years ago

The ESLint pre-commit hook doesn't stop a commit when a warning is thrown. I'd assume that also means the CI workflow still goes through, so we should make an extra script where ESLint actually exits with a non-zero code on warnings.