search

kirichkov / home_assistant-ble

Companion application for home-assistant, sending bluetooth low energy detection
21 stars 4 forks source link

Overriding device's name with device's ID from known_devices.yaml #4

Closed kirichkov closed 7 years ago

kirichkov commented 7 years ago

https://github.com/kamaradclimber/home_assistant-ble/blob/master/lib/home_assistant/ble.rb#L49

I see that you override the device's friendly name on purpose. Can you explain to me what's your reasoning behind it? For me that was unexpected when the device's name changed to it's dev_id.

kirichkov commented 7 years ago

I think I figured it out. Instead of using /api/services/device_tracker/see you are directly changing the state via /api/states/. I am not sure, however, that this will trigger an event for the state change, i.e. - state-based automations might not be running.

I think it's better to use the device_tracker API, instead of directly updating the state of the device.

kamaradclimber commented 7 years ago

You're right this route should be better.

Le sam. 1 avr. 2017 13:21, Georgi Kirichkov notifications@github.com a écrit :

I think I figured it out. Instead of using /api/services/device_tracker/see you are directly changing the state via /api/states/. I am not sure, however, that this will trigger an event for the state change, i.e. - state-based automations might not be running.

I think it's better to use the device_tracker API, instead of directly updating the state of the device.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kamaradclimber/home_assistant-ble/issues/4#issuecomment-290913990, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeu8Zpd7I7SCj05q4NEq0X4PgdbvwLnks5rrjNKgaJpZM4MwdKp .

kamaradclimber commented 7 years ago

fixed by #5