kirides / GD3D11

D3D11-Renderer for Gothic and Gothic 2
GNU General Public License v3.0
200 stars 18 forks source link

"Full-body" effects for NPCs #169

Closed dosinabox closed 3 days ago

dosinabox commented 2 weeks ago

Describe the bug "Full-body" effects are rendered in one point inside the NPC's model, instead of spreading equally. Examples:

instance Dragon_Undead(Mst_Default_Dragon_Undead)
{
    ...
    effect = "spellfx_undead_dragon";
    ...
};

instance ITAR_FireArmor_Addon(C_Item)
{
    ...
    effect = "SPELLFX_FIREARMOR";
    ...
};

To Reproduce

insert Dragon_Undead
insert ITAR_FireArmor_Addon

Expected behavior 362326288-6f6984dd-76c5-425e-a91e-b1384741009d

Screenshots 362322125-bd656ca8-d650-45c7-a8f4-d9071e475ab6

Please complete the following information):

dosinabox commented 2 weeks ago

Same for Fire Devils:

instance Shadowbeast_Addon_Fire(Mst_Default_Shadowbeast_Addon_Fire)
{
    ...
    effect = "SPELLFX_FIREARMOR";
};

Screenshot_7

dosinabox commented 2 weeks ago

But for C_ITEM instances the effects are fine:

instance ItRw_Addon_FireBow(C_Item)
{
    ...
    effect = "SPELLFX_FIREBOW";
    ...
};

Screenshot_4

kirides commented 3 days ago

At least the ones regarding the undead dragon (and possibly more) are fixed by @SaiyansKing

I'm currently in the process of merging a few sources back into this renderer. Initially those changes will be incorporated. Afterwards further changes from @lucifer602288 and @Shoun2137 are likely.

Please try the following version first: https://github.com/SaiyansKing/GD3D11/releases/tag/v17.8-dev16

dosinabox commented 3 days ago

Please try the following version first: https://github.com/SaiyansKing/GD3D11/releases/tag/v17.8-dev16

Works correctly!

Screenshot_3 Screenshot_4