search

kirienko / gourmet

Gourmet Recipe Manager
GNU General Public License v2.0
30 stars 14 forks source link

OS language not applied #340

Closed pled closed 3 years ago

pled commented 3 years ago

After installing gourmet-c3ece056.flatpakon Ubuntu 20.04 with locales set to FR, Gourmet menus are still in English.

Steps to Reproduce

  1. install gourmet-c3ece056.flatpak on Ubuntu 20.04 FR
  2. run Gourmet
  3. menus are in English language

Expected Behavior

Menus should be in French

Current OS settings

$ locale LANG=fr_FR.UTF-8 LANGUAGE= LC_CTYPE="fr_FR.UTF-8" LC_NUMERIC="fr_FR.UTF-8" LC_TIME="fr_FR.UTF-8" LC_COLLATE="fr_FR.UTF-8" LC_MONETARY="fr_FR.UTF-8" LC_MESSAGES="fr_FR.UTF-8" LC_PAPER="fr_FR.UTF-8" LC_NAME="fr_FR.UTF-8" LC_ADDRESS="fr_FR.UTF-8" LC_TELEPHONE="fr_FR.UTF-8" LC_MEASUREMENT="fr_FR.UTF-8" LC_IDENTIFICATION="fr_FR.UTF-8" LC_ALL=

 Database

I was previously running Gourmet 0.17 (deb package). I uninstalled it. After installing new gourmet-c3ece056.flatpak, all recipes were automatically filled in that new version (no import needed).

Environment

cydanil commented 3 years ago

Salut, thanks for reporting the issue!
I remember that it was further investigated in https://github.com/thinkle/gourmet/issues/1017, where the problem is nicely described.
I will look into resolving it.
It's not going to be immediate, though, but should be fixed in 2 releases from now.

pled commented 3 years ago

Thanks Cyril, you may close this one or set as duplicate. Sorry I missed thinkle#1017.

cydanil commented 3 years ago

Hi,
I'm slowly making progress with this the localization.

I see that few fields are translated:
image

Would you expect more of the application to be in French?
I'm asking in order to figure out how much of the internationalization is broken.

pled commented 3 years ago

Hi Cyril, Honestly, I would expect every field to be translated... in a perfect world ! ;) Now, this does not prevent me to use Gourmet, even with all fields in English. So it depends I suppose on how long it would take to repare the internationalization. Up to you to decide, it is already so nice to have Gourmet with Python 3 running ! Thank you and all the people involved for that. I cannot help in dev, but if you need someone to test or help, let me know. Thank you.

cydanil commented 3 years ago

Thanks for the feedback, I'm now able to run the application in different locales:

image

cydanil commented 3 years ago

This is at last fixed!
I'll be creating a new release in the coming days with it all.