kirienko / gourmet

Gourmet Recipe Manager
GNU General Public License v2.0
30 stars 14 forks source link

Fix pdf export when locale is set #363

Closed cydanil closed 3 years ago

cydanil commented 3 years ago

Description

Closes #362: there was an issue where the window for offering PDF export options weren't correctly set when switching from one locale to the other.
This was because of the preferences are saved with the option in a locale, but fail to load when another locale is used.

One way to fix this is to validate the values loaded from the preferences.toml file before using them, but this issue occurs not often enough to warrant such a complicated solution.
Thus, the values are now stored in english, and looked up in whatever locale is now used.

This also solve the problem, where we now have fixed locale handling, and people might now be using the application in their respective locales.

How Has This Been Tested?

This was tested by exporting one or several recipe(s) with LANGUAGES set to de_DE.utf-8, fr_FR.utf-8, and ru_RU.utf-8.
Off this, a minimal unit test was created.

Screenshots (if appropriate):

Types of changes

Checklist: