search

kirill-grouchnikov / radiance

Building modern, elegant and fast Swing applications
BSD 3-Clause "New" or "Revised" License
807 stars 89 forks source link

Maximize of Application Obscures the Windows Toolbar #488

Closed MichaelWDenney closed 2 weeks ago

MichaelWDenney commented 2 weeks ago

Version of Radiance (latest release is 8.0-SNAPSHOT)

8.0-SNAPSHOT

Sub-project (Common, Animation, Theming, Component, ...)

Ribbon

Version of Java (current minimum is 9)

21.0.4+7

Version of OS

Windows 11

The issue you're experiencing (expected vs actual, screenshot, stack trace etc)

This is reproducible using the BasicCheckRibbon demo.

Start the application and click the 'Maximize' button.

Expected behaviour: The application window expands to fill the current Windows screen while leaving the Windows toolbar visible. Actual behaviour: The application window expands to fill the entire current Windows screen thus obscuring the Windows toolbar.

(See the attached full screen shots. When Word is maximized, the toolbar is visible at the bottom of the screen. When the demo is maximized, the toolbar cannot be seen.) image image

kirill-grouchnikov commented 2 weeks ago

This sounds like https://github.com/kirill-grouchnikov/radiance/issues/379 that was fixed by https://github.com/kirill-grouchnikov/radiance/commit/97e9bb7f7432561e467d598811888f036857d7c4

Do you see the same issue in the main Radiance demo app (org.pushingpixels.radiance.demo.theming.main.Check)?

kirill-grouchnikov commented 2 weeks ago

Ah, I later reverted it. See the comment that starts in https://github.com/kirill-grouchnikov/radiance/blob/sunshine/theming/src/main/java/org/pushingpixels/radiance/theming/internal/utils/RadianceTitlePane.java#L994 - there's nothing that I can do in the library to make it work reliably across different JDK versions.

kirill-grouchnikov commented 2 weeks ago

The revert was in https://github.com/kirill-grouchnikov/radiance/commit/c8f624d5e5152327c346c445fd652649a167092f

Closing this

MichaelWDenney commented 2 weeks ago

Hmmm. We are using:

openjdk version "21.0.4" 2024-07-16 LTS
OpenJDK Runtime Environment Temurin-21.0.4+7 (build 21.0.4+7-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.4+7 (build 21.0.4+7-LTS, mixed mode)

Maybe it's a regression in Java?

kirill-grouchnikov commented 2 weeks ago

See if https://github.com/kirill-grouchnikov/radiance/issues/443#issuecomment-1423397066 helps with your particular setup

MichaelWDenney commented 2 weeks ago

Yes, it appears to resolve it on Windows. I'll have to test whether there is any impact on other platforms. Thanks for that.