search

kirill-grouchnikov / substance

A modern and high-performant Swing look-and-feel library
164 stars 109 forks source link

JitPack deployment #85

Closed RoiEXLab closed 6 years ago

RoiEXLab commented 6 years ago

Disclaimer: I know about #20 I just thought this would be a good alternative at no cost other than keeping the build.xml working. So if you think this is still too much additional work, feel free to close this issue without any further comment.

jitpack.io is a service that builds whatever github repository is specified and stores build atrifacts in a maven repository. Under normal circumstances it would just work with no additional work required, however jitpack seems to have some trouble to compile with the trident dependency, and therefore compilation fails with symbol not found errors. ant error log

Unfortunately the documentation on ant builds isn't really good, but I think adding some dependencies to targets might already do the trick.

kirill-grouchnikov commented 6 years ago

Trident's build.xml has elements that copy the compiled trident.jar to substance/lib and flamingo/lib (lines 141/142).

However, instead of referencing that copy in substance/lib in line 67 of Substance's build.xml, it references the ../trident one. The same applies to flamingo build file.

So I'm going to fix these two incorrect references. Otherwise, if this doesn't fix the jitpack build issue, I honestly wouldn't care. If it does, great.

RoiEXLab commented 6 years ago

Your fix worked Thank you 👍

RoiEXLab commented 6 years ago

Note that currently only using the 'com.github.kirill-grouchnikov:substance:master-SNAPSHOT' artifact works. Once you create a new github release people can just use the current version and download that instead.

kirill-grouchnikov commented 6 years ago

Thanks for verifying