search

kirillseva / cacher

In memory cache interface for R
4 stars 4 forks source link

Add installation section to README #12

Closed captainpete closed 6 years ago

captainpete commented 6 years ago

Nice project :)

peterhurford commented 6 years ago

Thanks for the submission! Can you change the title of the PR and add a PR description? It is not very descriptive as to what is happening at the moment.

captainpete commented 6 years ago

Ah! Sorry the other stuff on master wasn't meant to make it into this PR. I've reset the branch, only intended to do the README changes :)

Have added the ## Installation header as suggested.

peterhurford commented 6 years ago

@captainpete Ah, perfect, thanks! 👍

peterhurford commented 6 years ago

@captainpete I approve, but I'd want @robertzk to release his rejection before merging.

robertzk commented 6 years ago

@captainpete The other changes looked interesting too, feel free to re-submit!

captainpete commented 6 years ago

Thanks!

kirillseva commented 6 years ago

@captainpete thank you for your contribution <3