search

kirillseva / cacher

In memory cache interface for R
4 stars 4 forks source link

Public peek #13

Closed captainpete closed 6 years ago

captainpete commented 6 years ago

Hi all, this adds the peek method to the public API. Public peek function returns value, like get but without timestamp modification. Added set/get/peek tests for last_accessed.

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.37%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #13      +/-   ##
=========================================
+ Coverage   88.33%   88.7%   +0.37%     
=========================================
  Files           1       1              
  Lines          60      62       +2     
=========================================
+ Hits           53      55       +2     
  Misses          7       7
Impacted Files Coverage Δ
R/lru.R 88.7% <100%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0da6b4b...416c228. Read the comment docs.

peterhurford commented 6 years ago

@captainpete Can you increment the package version in the DESCRIPTION file for this change? And add a line to the NEWS for the change? (Or we can do so before merging /cc @robertzk @kirillseva)

peterhurford commented 6 years ago

Oops, hit close by mistake!

captainpete commented 6 years ago

no problem, version bumped to 0.1.1, added news

peterhurford commented 6 years ago

Awesome, thanks @captainpete. I'll let @kirillseva and/or @robertzk do the final review / merge.

kirillseva commented 6 years ago

thank you very much @captainpete for the work you've put into this and @peterhurford for reviewing! looks good to me