search

kirillseva / cacher

In memory cache interface for R
4 stars 4 forks source link

LRUcache refactor #4

Closed elainexmas closed 8 years ago

elainexmas commented 9 years ago

DRY up existing cache classes using inheritance.

Still need to add time-limited cache type. This PR just addresses existing cache types.

codecov-io commented 9 years ago

Current coverage is 100.00%

Merging #4 into master will not affect coverage as of 70aa63b

@@            master      #4   diff @@
======================================
  Files            1       1       
  Stmts            1       3     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit              1       3     +2
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 70aa63b

Powered by Codecov. Updated on successful CI builds.

elainexmas commented 8 years ago

@peterhurford @kirillseva Any other comments?

peterhurford commented 8 years ago

Looks good to me but I don't really know that much about R6 :+1:

Any changes or additions that need to go into test coverage?

kirillseva commented 8 years ago

Hi! Thanks for the PR and sorry for being so unresponsive. I'll take a look as soon as I get home!

Sent from my iPhone

On Nov 17, 2015, at 14:35, Elaine K. Lee notifications@github.com wrote:

@peterhurford @kirillseva Any other comments?

— Reply to this email directly or view it on GitHub.

kirillseva commented 8 years ago

This is awesome! Thank you so much for this PR @elainexmas!

Just a couple small things I'd like to get addressed before merging

robertzk commented 8 years ago

I like it.

kirillseva commented 8 years ago

So do I!