Naming consistency "Lisk"

kirillshevch / react-cryptocoins

Сryptocurrencies icons as React components

MIT License

36 stars 2 forks source link

Closed kuy closed 6 years ago

kuy commented 6 years ago

Hello, I found an inconsistent name: Lisk. Lisk's symbol is LSK.

export LiskAlt from './icons/LISK-alt';
export Lisk from './icons/LISK';

Can I send PR to fix this?

kirillshevch commented 6 years ago

Ok, but you need to solve this through condition in build.js for keep naming for the next versions

kuy commented 6 years ago

Umm, I didn't notice that symbol name is coming from SVG files of allienworks/cryptocoins repository.

kirillshevch commented 6 years ago

Solved in #12