kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.54k stars 61 forks source link

KeyboardToolbar component with different text input types #374

Closed IvanIhnatsiuk closed 5 months ago

IvanIhnatsiuk commented 5 months ago

Describe the bug

Hello @kirillzyusko . Thank you for your library it's really great and powerful.

I wanted to add KeyboardToolbar component in my current app and I found several issues.

  1. When I switch between the numeric and text keyboard, it changes the KeyboardToolbar offset with animation, but I think this behaviour should be the same as the native keyboard (without animation).
  2. The second problem is that keyboard pressable elements have a different animation when clicked on: different color of ripple effect. ripple effect of keyboard elements is faster.

Repo for reproducing

I think that you can reproduce this issue in your example app in keyboard toolbar example.

To Reproduce Steps to reproduce the behavior:

  1. Focus on number text input
  2. Change focus via toolbar to another non number text input
  3. See that KeyboardToolbar changes with animation

Expected behavior

Keyboard toolbar should change his offset like native keyboard toolbar.

Screenshots

https://github.com/kirillzyusko/react-native-keyboard-controller/assets/86000012/c70ee495-d833-41e2-b34d-2b5ca8e80fd0

https://github.com/kirillzyusko/react-native-keyboard-controller/assets/86000012/20970eb0-05fa-4880-8bbe-9fccf476a954

Additional context

N/A