kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.54k stars 61 forks source link

fix: android build fail with rnx kit & treeShaking enabled #380

Closed ashwin1014 closed 5 months ago

ashwin1014 commented 5 months ago

📜 Description

Fixed build issues when using @rnx-kit.

💡 Motivation and Context

When using tools like @rnx-kit from microsoft, which uses esbuild to handle bundling and also enables treeShaking, the build fails

📢 Changelog

📸 Screenshots (if appropriate):

Screenshot 2024-03-07 at 23 01 07 Screenshot 2024-03-07 at 23 00 53
kirillzyusko commented 5 months ago

@ashwin1014 you also need to run yarn prettier '**/*' --write --ignore-unknown to fix eslint stage

And there is one more eslint violation - please, fix it 🙏

kirillzyusko commented 5 months ago

@ashwin1014 by the way - did you check? Do these changes help to fix build issues?

ashwin1014 commented 5 months ago

@ashwin1014 by the way - did you check? Do these changes help to fix build issues?

i was usually doing these changes manually from node_modules on my project. Then it used to build correctly

ashwin1014 commented 5 months ago

@ashwin1014 you also need to run yarn prettier '**/*' --write --ignore-unknown to fix eslint stage

And there is one more eslint violation - please, fix it 🙏

Will do

kirillzyusko commented 5 months ago

@ashwin1014 thank you for your contribution!