kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.54k stars 61 forks source link

fix: stable iOS e2e tests #392

Closed kirillzyusko closed 4 months ago

kirillzyusko commented 5 months ago

πŸ“œ Description

Make iOS tests on CI stable again.

πŸ’‘ Motivation and Context

Looks like after updating some of runners to XCode 15.3 booting up a simulator takes long time (actually it boots pretty fast, but after that CPU usage is close to 100% for quite big period of time). As a result tests are failing because of timeout.

I've tried many things - switching to other XCode versions, increasing timeout, changing the order of tests, changing runners, pre-booting simultator etc. and still tests very flaky in some cases.

However what I discovered is that after ~20mins and after several failures tests start to work okay. So I decided to add --retry 2 flag to overcome the problem of flaky simulator - it makes CI green again. But if a regression really introduced - it'll fail anyway just with linger time of execution πŸ™‚

πŸ“’ Changelog

E2E

CI

πŸ€” How Has This Been Tested?

Tested on CI.

πŸ“ Checklist

github-actions[bot] commented 5 months ago

πŸ“Š Package size report

Current size Target Size Difference
130819 bytes 130819 bytes 0 bytes πŸ“‰
kirillzyusko commented 5 months ago

Looks like:

I opened an issue in detox - https://github.com/wix/Detox/issues/4415