However it looks like in current setup (RN 0.73, REA 3.8.0) such way is not working and onScroll property still gets ignored š
So in this PR I followed a different path: initially I wanted to fire this handler via runOnJS, but we can not follow a full signature of the method, since REA has only nativeEvent property (and indeed in this case some properties would be simply missing).
The different path was to update a shared value from JS thread and call a callback as usually - it fixes a problem in old code and in a new, so for now this approach looks decent š
Let's see how it works in a wild life š
Also in this PR I'm changing content of tea.yaml - it should be done in separate PR, but I don't want to open another PR just to fix quotes, so decided to merge everything in a single one š
š Description
Fixed firing of
onScroll
inKeyboardAwareScrollView
š” Motivation and Context
Initially it was fixed in https://github.com/kirillzyusko/react-native-keyboard-controller/pull/339 and I'm sure it was working š
However it looks like in current setup (RN 0.73, REA 3.8.0) such way is not working and
onScroll
property still gets ignored šSo in this PR I followed a different path: initially I wanted to fire this handler via
runOnJS
, but we can not follow a full signature of the method, since REA has onlynativeEvent
property (and indeed in this case some properties would be simply missing).The different path was to update a shared value from JS thread and call a callback as usually - it fixes a problem in old code and in a new, so for now this approach looks decent š
Let's see how it works in a wild life š
Also in this PR I'm changing content of
tea.yaml
- it should be done in separate PR, but I don't want to open another PR just to fix quotes, so decided to merge everything in a single one šCloses https://github.com/kirillzyusko/react-native-keyboard-controller/issues/337
š¢ Changelog
JS
onScroll
in callback;FS (file system)
'
fortea.yaml
;š¤ How Has This Been Tested?
Tested manually on iPhone 15 Pro.
šø Screenshots (if appropriate):
š Checklist